Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite install procedure and fix #151 #196

Merged
merged 15 commits into from
Sep 26, 2022
Merged

Rewrite install procedure and fix #151 #196

merged 15 commits into from
Sep 26, 2022

Conversation

flagarde
Copy link
Collaborator

@flagarde flagarde commented Sep 20, 2022

Hi, I have fixed some problems on the install (some still remains) and fixed #151

Copy link
Collaborator

@MCWertGaming MCWertGaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes look good, thank you really much! I just have some questions added.

Besides that please give your commits names that explain what you have done and at best also why you did it. It makes it a lot easier for me to review you changes and understand why things were changed. If the changes are small and just fix something git has the option to amend a commit using git commit --ammend. It basically adds the new changes to the last commit (you need to force push here though otherwise git might do a fast forward pull before pushing which then creates a merge commit).

examples/colors.cpp Show resolved Hide resolved
ci/compile_test.ps1 Show resolved Hide resolved
@MCWertGaming MCWertGaming added the enhancement New feature or request label Sep 25, 2022
@MCWertGaming MCWertGaming added this to the V1.0.0 milestone Sep 25, 2022
@MCWertGaming MCWertGaming merged commit 7ec4eec into jupyter-xeus:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

automatically copy colors.cpp from the examples for stand-alone test
2 participants