-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite install procedure and fix #151 #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes look good, thank you really much! I just have some questions added.
Besides that please give your commits names that explain what you have done and at best also why you did it. It makes it a lot easier for me to review you changes and understand why things were changed. If the changes are small and just fix something git has the option to amend a commit using git commit --ammend
. It basically adds the new changes to the last commit (you need to force push here though otherwise git might do a fast forward pull before pushing which then creates a merge commit).
Hi, I have fixed some problems on the install (some still remains) and fixed #151