Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required same version of nlohmann_json in dependencies #390

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

JohanMabille
Copy link
Member

@JohanMabille JohanMabille commented Mar 20, 2024

Fixes #381.
Should be updated and marked as "ready for review" when nlohmann_json 3.11.3 is available on conda-forge, to avoid breaking debian and emscripten packages.

@JohanMabille JohanMabille force-pushed the nlohmann_check branch 2 times, most recently from 920dbbb to 6176919 Compare March 20, 2024 03:28
@JohanMabille JohanMabille marked this pull request as ready for review March 20, 2024 03:28
@JohanMabille JohanMabille changed the title Required exact version of nlohmann_json Required exact version of nlohmann_json in dependencies Mar 20, 2024
@JohanMabille JohanMabille changed the title Required exact version of nlohmann_json in dependencies Required same version of nlohmann_json in dependencies Mar 20, 2024
@JohanMabille JohanMabille merged commit e6d62ff into jupyter-xeus:main Mar 20, 2024
10 checks passed
@JohanMabille JohanMabille deleted the nlohmann_check branch March 20, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ABI break with minor version bump in nlohmann::json
2 participants