fix initial cursor in delete script #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empty string is not a valid cursor in latest redis-server, unclear if it ever should have been repeat...until always executes block at least once logging closure fixed as well
- redis.close deprecated in favor of redis.aclose - make sure to close external redis proxy client to avoid warnings during teardown
|
I also fixed the warnings about unclosed connections caused by not closing the redis client in the external_redis fixture, and updated to use |
manics
reviewed
Aug 21, 2024
minrk
commented
Aug 21, 2024
| @@ -115,7 +121,7 @@ def _register_delete_script(self): | |||
| """ | |||
| _delete_lua = """ | |||
| local all_keys = {}; | |||
| local cursor = ""; | |||
| local cursor = "0"; | |||
There was a problem hiding this comment.
This line is the whole real fix for the bug.
manics
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
empty string is not a valid cursor in latest redis-server (seems valid in 7.2.5, not 7.4, but not 100% sure), unclear if it ever should have been.
repeat...until always executes block at least once, so didn't need the empty string to not match the
untilcondition.logging closure fixed as well
closes #252