Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cf-xarray 0.8.0 and newer. #78

Merged
merged 5 commits into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.9", "3.10", "3.11", "3.12"]

steps:
- uses: actions/checkout@v3
Expand Down
8 changes: 7 additions & 1 deletion doc/whatsnew.rst
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,16 @@ What's new
v0.3.1 (unreleased)
-------------------

Breaking changes
~~~~~~~~~~~~~~~~

- Require Python 3.9 or newer (:pull:`78`).

Bug fixes
~~~~~~~~~

- Add missing optional dependency to dask_ (:issue:`73`, :pull:`76`).
- Add missing optional dependency to dask_ (:issue:`74`, :pull:`76`).
- Fix incompatibility with cf_xarray_ 0.8.0 (:issue:`73`, :pull:`78`).

.. _dask: https://www.dask.org

Expand Down
6 changes: 3 additions & 3 deletions hyoga/core/accessor.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2021-2022, Julien Seguinot (juseg.github.io)
# Copyright (c) 2021-2024, Julien Seguinot (juseg.dev)
# GNU General Public License v3.0+ (https://www.gnu.org/licenses/gpl-3.0.txt)

"""
Expand Down Expand Up @@ -179,8 +179,8 @@ def assign(self, **standard_variables):
f"{variable_name}_ instead", UserWarning)
variable_name += '_'

# link variable data to short name
variables[variable_name] = data
# link variable data to short name (skip coords, see #74)
variables[variable_name] = data.variable

# assign new variables and return a new dataset
return self._ds.assign(variables)
Expand Down
4 changes: 2 additions & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ classifiers =
[options]
packages = find:
install_requires =
cf_xarray<0.8.0
cf_xarray
geopandas
matplotlib
requests
rioxarray
scipy
xarray
python_requires = >=3.8
python_requires = >=3.9

[options.extras_require]
docs =
Expand Down
Loading