Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add process-compose defaults module #466

Merged
merged 1 commit into from
Feb 23, 2025
Merged

feat: Add process-compose defaults module #466

merged 1 commit into from
Feb 23, 2025

Conversation

shivaraj-bh
Copy link
Member

resolves #459

@shivaraj-bh
Copy link
Member Author

This PR also lays ground work by structuring some process-compose specific definitions under /nix/process-compose, paving way for better structuring multiple backend definitions in #448

srid
srid approved these changes Feb 23, 2025
View reviewed changes
Copy link
Member

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If you are looking to re-arrange files under ./nix/process-compose I suggest doing that in a PR and merging it (single commit) before further work.

@shivaraj-bh shivaraj-bh merged commit 65c47ee into main Feb 23, 2025
2 checks passed
@shivaraj-bh shivaraj-bh deleted the pc-defaults branch February 23, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srid srid srid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wish: Disable the process-compose HTTP server by default
2 participants
@shivaraj-bh @srid