Skip to content

Commit

Permalink
Update with the ruby 3.4 stable release
Browse files Browse the repository at this point in the history
Keep .ruby-version until which is updated by nixpkgs
  • Loading branch information
kachick committed Dec 25, 2024
1 parent 8d086e1 commit d2c58f9
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
# macos is covered in nix ci
os: ['ubuntu-24.04']
# Due to https://github.com/actions/runner/issues/849, we have to use quotes for 'n.0'
ruby: ['head', '3.3', '3.2']
ruby: ['head', '3.4', '3.3']
runs-on: ${{ matrix.os }}
env:
# https://github.com/kachick/ruby-ulid/blob/104834846baf5caa1e8536a11c43acdd56fc849c/CONTRIBUTING.md#adding-dependencies-for-this-gem
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
# - macos-13 # x86_64 - CPU arch does not affect for this gem (I think)
# - windows-2022 - Too slow. Please tell me if any Windows user is using this gem.
# For actual use-case, head is needless here
ruby: ['3.3', '3.2']
ruby: ['3.4', '3.3']
runs-on: ${{ matrix.os }}
steps:
# Required to checkout for gh command
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ require:
- rubocop-thread_safety

AllCops:
TargetRubyVersion: 3.2
TargetRubyVersion: 3.3
DisplayCopNames: true
Exclude:
- '**/vendor/**/*'
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,10 @@ $ bundle exec ruby benchmark/the_added_file.rb
- Basically should be reduced. ref: [#91](kachick/ruby-ulid#91), [#236](kachick/ruby-ulid#236)
- When having some objects, they should be frozen. ref: [#126](kachick/ruby-ulid#126)

## Tasks to drop Ruby 3.2
## Tasks to drop Ruby 3.3

- grep `RUBY_VERSION` guards
- grep `3.2` and `3.3`
- grep `3.3` and `3.4`
- Update gemspec and `TargetRubyVersion` in .rubocop.yml

## Use profiler
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Instead, herein is proposed ULID:

### Install

Tested only in the last 2 Rubies. So you need Ruby 3.2 or higher.
Tested only in the last 2 Rubies. So you need Ruby 3.3 or higher.

Add this line to your `Gemfile`.

Expand Down
2 changes: 1 addition & 1 deletion ruby-ulid.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Gem::Specification.new do |gem|
'rubygems_mfa_required' => 'true'
}

gem.required_ruby_version = Gem::Requirement.new('>= 3.2')
gem.required_ruby_version = Gem::Requirement.new('>= 3.3')

# common

Expand Down

0 comments on commit d2c58f9

Please sign in to comment.