Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rbs requirement from ~> 3.5.2 to ~> 3.5.3 in the rbs-dependencies group #587

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 26, 2024

Updates the requirements on rbs to permit the latest version.
Updates rbs to 3.5.3

Release notes

Sourced from rbs's releases.

3.5.3

Release note

Library changes

  • Backport GC fix PR (#1977)
Changelog

Sourced from rbs's changelog.

CHANGELOG

3.5.1 (2024-06-07)

Library changes

  • Add explicit dependency on the logger gem (#1865)
  • Make c99, c23 compatible (#1870)

Miscellaneous

  • Don't try to sign git commits when running tests (#1867)

3.5.0 (2024-06-06)

Signature updates

Language updates

  • Fix proc type syntax (#1807)
  • Function types with untyped parameter (#1806)
  • Fix record type (#1732)
  • parser: enable record types with optional fields (#1717)

Library changes

  • Drop dependency on abbrev (#1866)

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Updates the requirements on [rbs](https://github.com/ruby/rbs) to permit the latest version.

Updates `rbs` to 3.5.3
- [Release notes](https://github.com/ruby/rbs/releases)
- [Changelog](https://github.com/ruby/rbs/blob/master/CHANGELOG.md)
- [Commits](ruby/rbs@v3.5.2...v3.5.3)

---
updated-dependencies:
- dependency-name: rbs
  dependency-type: direct:development
  dependency-group: rbs-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Aug 26, 2024
@kachick kachick self-assigned this Aug 26, 2024
@kachick
Copy link
Owner

kachick commented Aug 26, 2024

Failed only in ruby-head

===============================================================================
Error: test_range_elements(TestULIDUseCase): NoMethodError: undefined method '+' for an instance of ULID
/home/runner/work/ruby-ulid/ruby-ulid/test/core/test_ulid_usecase.rb:21:in 'Range#step'
/home/runner/work/ruby-ulid/ruby-ulid/test/core/test_ulid_usecase.rb:21:in 'Enumerator#each'
/home/runner/work/ruby-ulid/ruby-ulid/test/core/test_ulid_usecase.rb:21:in 'Enumerable#to_a'
/home/runner/work/ruby-ulid/ruby-ulid/test/core/test_ulid_usecase.rb:21:in 'TestULIDUseCase#test_range_elements'
===============================================================================
Finished in 0.31[9](https://github.com/kachick/ruby-ulid/actions/runs/10551862741/job/29229876886?pr=587#step:5:10)641326 seconds.
122 tests, 7764 assertions, 0 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications
rake aborted!
Command failed with status (1)
<internal:array>:53:in 'Array#each'
<internal:array>:53:in 'Array#each'
<internal:array>:53:in 'Array#each'
Tasks: TOP => test_all => test_core

assert_equal([begin_ulid, ulid3, ulid5], include_end.step(2).to_a)

https://github.com/ruby/ruby/blame/2e07c13049a887c22849e77648838f040b0759b0/NEWS.md#L46
ruby/ruby#7444
https://bugs.ruby-lang.org/issues/18368
ruby/ruby@d450f9d

@kachick
Copy link
Owner

kachick commented Aug 26, 2024

💭 I don't want to define ULID#+ for this ruby change...

@kachick
Copy link
Owner

kachick commented Aug 26, 2024

ruby-ulid/README.md

Lines 283 to 288 in 49d6be0

#### As element in Enumerable
`ULID#next` and `ULID#succ` returns next(successor) ULID.\
Especially `ULID#succ` makes it possible `Range[ULID]#each`.
NOTE: However basically `Range[ULID]#each` should not be used. Incrementing 128 bits IDs are not reasonable operation in most cases.

@kachick
Copy link
Owner

kachick commented Aug 26, 2024

assert_equal([begin_ulid, ulid3, ulid5], include_end.step(2).to_a)
assert_equal([begin_ulid, ulid4], include_end.step(3).to_a)
assert_equal([begin_ulid, end_ulid], include_end.step(5).to_a)
assert_equal([begin_ulid, ulid3, ulid5], exclude_end.step(2).to_a)
assert_equal([begin_ulid, ulid4], exclude_end.step(3).to_a)
assert_equal([begin_ulid], exclude_end.step(5).to_a)

Even if I define +, Last test case may raise error for boundary ULID? => Then need similar and more handlings as

ruby-ulid/lib/ulid.rb

Lines 452 to 465 in 49d6be0

# @return [ULID, nil] when called on ULID as `7ZZZZZZZZZZZZZZZZZZZZZZZZZ`, returns `nil` instead of ULID
def succ
succ_int = @integer.succ
if succ_int >= MAX_INTEGER
if succ_int == MAX_INTEGER
MAX
else
nil
end
else
ULID.from_integer(succ_int)
end
end
alias_method(:next, :succ)

@kachick
Copy link
Owner

kachick commented Aug 26, 2024

This CI failure is not related to RBS changes. So extracted into #590

@kachick kachick merged commit d270926 into main Aug 26, 2024
14 of 16 checks passed
@kachick kachick deleted the dependabot/bundler/rbs-dependencies-b181fbedc8 branch August 26, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant