Skip to content

Commit

Permalink
-renamed http::ResponseView to http::ClientResponse;
Browse files Browse the repository at this point in the history
-renamed http::RequestView to http::Request;
-renamed http::Request to http::ClientRequest;
  • Loading branch information
kamchatka-volcano committed Jul 10, 2024
1 parent f37bfa0 commit 13ac1a6
Show file tree
Hide file tree
Showing 9 changed files with 47 additions and 29 deletions.
18 changes: 18 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,26 @@ SealLake_Bundle(
TEXT_REPLACEMENTS
"namespace http" "namespace asyncgi::http"
"HOT_TEACUP_" "ASYNCGI_HOT_TEACUP_"
"Request::" "ClientRequest::"
"class Request {" "class ClientRequest {"
"Request(" "ClientRequest("
"REQUEST_H" "CLIENT_REQUEST_H"
"RequestView::" "Request::"
"class RequestView {" "class Request {"
"RequestView(" "Request("
"REQUEST_VIEW_H" "REQUEST_H"
"RequestView" "Request"
"ResponseView::" "ClientResponse::"
"class ResponseView {" "class ClientResponse {"
"ResponseView(" "ClientResponse("
"RESPONSE_VIEW_H" "CLIENT_RESPONSE_H"
"ResponseView" "ClientResponse"
)

file(RENAME include/asyncgi/http/request.h include/asyncgi/http/client_request.h)
file(RENAME include/asyncgi/http/request_view.h include/asyncgi/http/request.h)
file(RENAME include/asyncgi/http/response_view.h include/asyncgi/http/client_response.h)

set(SRC
src/asiodispatcher.cpp
src/io.cpp
Expand Down
4 changes: 2 additions & 2 deletions examples/example_client.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ int main()
"127.0.0.1",
9088,
#endif
http::Request{http::RequestMethod::Get, "/"},
[&io](const std::optional<http::ResponseView>& response)
http::ClientRequest{http::RequestMethod::Get, "/"},
[&io](const std::optional<http::ClientResponse>& response)
{
if (response)
std::cout << response->body() << std::endl;
Expand Down
4 changes: 2 additions & 2 deletions examples/example_client_in_processor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ struct RequestPage{
"127.0.0.1",
9088,
#endif
http::Request{http::RequestMethod::Get, "/"},
[responder](const std::optional<http::ResponseView>& reqResponse) mutable
http::ClientRequest{http::RequestMethod::Get, "/"},
[responder](const std::optional<http::ClientResponse>& reqResponse) mutable
{
if (reqResponse)
responder.send(std::string{reqResponse->body()});
Expand Down
12 changes: 6 additions & 6 deletions include/asyncgi/client.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
#include "errors.h"
#include "types.h"
#include "detail/serviceholder.h"
#include "http/request.h"
#include "http/response_view.h"
#include "http/client_request.h"
#include "http/client_response.h"
#include <filesystem>
#include <functional>
#include <memory>
Expand All @@ -32,8 +32,8 @@ class Client {
std::chrono::milliseconds timeout = std::chrono::seconds{3});
void makeRequest(
const std::filesystem::path& socketPath,
const http::Request& request,
const std::function<void(std::optional<http::ResponseView>)>& responseHandler,
const http::ClientRequest& request,
const std::function<void(std::optional<http::ClientResponse>)>& responseHandler,
std::chrono::milliseconds timeout = std::chrono::seconds{3});

void makeRequest(
Expand All @@ -45,8 +45,8 @@ class Client {
void makeRequest(
std::string_view ipAddress,
uint16_t port,
const http::Request& request,
const std::function<void(std::optional<http::ResponseView>)>& responseHandler,
const http::ClientRequest& request,
const std::function<void(std::optional<http::ClientResponse>)>& responseHandler,
std::chrono::milliseconds timeout = std::chrono::seconds{3});

void disconnect();
Expand Down
6 changes: 3 additions & 3 deletions include/asyncgi/request.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include "detail/lazyinitialized.h"
#include "http/cookie_view.h"
#include "http/query_view.h"
#include "http/request_view.h"
#include "http/request.h"
#include "http/types.h"
#include <functional>
#include <map>
Expand Down Expand Up @@ -58,11 +58,11 @@ class Request {

private:
const fcgi::Request& fcgiRequest() const;
const http::RequestView& httpRequest() const;
const http::Request& httpRequest() const;

private:
sfun::member<const fcgi::Request&> fcgiRequest_;
detail::LazyInitialized<http::RequestView> httpRequest_;
detail::LazyInitialized<http::Request> httpRequest_;
};

} // namespace asyncgi
Expand Down
8 changes: 4 additions & 4 deletions src/client.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ void Client::makeRequest(

void Client::makeRequest(
const std::filesystem::path& socketPath,
const http::Request& request,
const std::function<void(std::optional<http::ResponseView>)>& responseHandler,
const http::ClientRequest& request,
const std::function<void(std::optional<http::ClientResponse>)>& responseHandler,
std::chrono::milliseconds timeout)
{
if (!clientService_.has_value())
Expand All @@ -71,8 +71,8 @@ void Client::makeRequest(
void Client::makeRequest(
std::string_view ipAddress,
uint16_t port,
const http::Request& request,
const std::function<void(std::optional<http::ResponseView>)>& responseHandler,
const http::ClientRequest& request,
const std::function<void(std::optional<http::ClientResponse>)>& responseHandler,
std::chrono::milliseconds timeout)
{
if (!clientService_.has_value())
Expand Down
8 changes: 4 additions & 4 deletions src/clientservice.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ void ClientService::makeRequest(

void ClientService::makeRequest(
const fs::path& socketPath,
const http::Request& request,
const std::function<void(std::optional<http::ResponseView>)>& responseHandler,
const http::ClientRequest& request,
const std::function<void(std::optional<http::ClientResponse>)>& responseHandler,
std::chrono::milliseconds timeout)
{
if (requestProcessorQueue_)
Expand Down Expand Up @@ -143,8 +143,8 @@ void ClientService::makeRequest(
void ClientService::makeRequest(
std::string_view ipAddress,
uint16_t port,
const http::Request& request,
const std::function<void(std::optional<http::ResponseView>)>& responseHandler,
const http::ClientRequest& request,
const std::function<void(std::optional<http::ClientResponse>)>& responseHandler,
std::chrono::milliseconds timeout)
{
if (requestProcessorQueue_)
Expand Down
12 changes: 6 additions & 6 deletions src/clientservice.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
#include <asyncgi/detail/external/sfun/member.h>
#include <asyncgi/detail/external/sfun/optional_ref.h>
#include <asyncgi/errors.h>
#include <asyncgi/http/client_request.h>
#include <asyncgi/http/client_response.h>
#include <fcgi_responder/requester.h>
#include <hot_teacup/request.h>
#include <hot_teacup/response_view.h>
#include <filesystem>
#include <vector>

Expand All @@ -37,8 +37,8 @@ class ClientService {
std::chrono::milliseconds timeout = std::chrono::seconds{3});
void makeRequest(
const std::filesystem::path& socketPath,
const http::Request& request,
const std::function<void(std::optional<http::ResponseView>)>& responseHandler,
const http::ClientRequest& request,
const std::function<void(std::optional<http::ClientResponse>)>& responseHandler,
std::chrono::milliseconds timeout = std::chrono::seconds{3});

void makeRequest(
Expand All @@ -50,8 +50,8 @@ class ClientService {
void makeRequest(
std::string_view ipAddress,
uint16_t port,
const http::Request& request,
const std::function<void(std::optional<http::ResponseView>)>& responseHandler,
const http::ClientRequest& request,
const std::function<void(std::optional<http::ClientResponse>)>& responseHandler,
std::chrono::milliseconds timeout = std::chrono::seconds{3});

void disconnect();
Expand Down
4 changes: 2 additions & 2 deletions src/request.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Request::Request(const fcgi::Request& request)
: fcgiRequest_{request}
, httpRequest_{[this]
{
return http::RequestView{
return http::Request{
fcgiRequest().hasParam("REQUEST_METHOD") ? fcgiRequest().param("REQUEST_METHOD")
: std::string_view{},
fcgiRequest().hasParam("REMOTE_ADDR") ? fcgiRequest().param("REMOTE_ADDR")
Expand All @@ -33,7 +33,7 @@ const fcgi::Request& Request::fcgiRequest() const
return fcgiRequest_;
}

const http::RequestView& Request::httpRequest() const
const http::Request& Request::httpRequest() const
{
return httpRequest_;
}
Expand Down

0 comments on commit 13ac1a6

Please sign in to comment.