Store some strings in variables in gptel-rewrite.el #677
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces customization options for prompts used in the `gptel-rewrite` function. It introduces `gptel-rewrite--assistant-instruction-question` for defining the prompt and `gptel-rewrite--default-rewrite-prefix` for the default "Rewrite: " prefix.
|
This could be a good idea. However, if these are user-customizable variables, it may be more appropriate to define them with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for creating this great package.
I've been exploring
gptel-rewrite, and I primarily use language models in Finnish. I noticed that each rewrite request includes the prompt string "What is the required change?". This may cause issues, particularly with Google's Gemini, which sometimes identifies itself as an English model and declines to process Finnish text. To address this, I've modified the code to make this string configurable. Additionally, I've made the "Rewrite: " string configurable as well, as I find it useful to customize. I'm willing to contribute these changes, so please let me know what adjustments are needed for them to be accepted. I feel the change is necessary to support non-english use cases.