Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIP-49 Add ruff - first pass #94

Merged
merged 2 commits into from
Jun 11, 2024
Merged

UIP-49 Add ruff - first pass #94

merged 2 commits into from
Jun 11, 2024

Conversation

briehl
Copy link
Collaborator

@briehl briehl commented May 31, 2024

This is the first pass at adding ruff and running the checker.

There are a few that don't pass, but those will likely get ignored in a later PR. As will adding the linting check and more specific configuration.

It's going to be a little while before that's worth doing, as this has been sitting around since the pre-typing days and just now getting updated to py 3.12. But I wanted to have a linting once-over, at least.

Next up, get the tests working!

@briehl briehl requested a review from ialarmedalien May 31, 2024 20:09
@briehl
Copy link
Collaborator Author

briehl commented Jun 3, 2024

Other than the changes to the run_tests.yaml GitHub action , .gitignore, and the requirements files, all changes here are automatic fixed by ruff. I skipped opening up all the ruff options in this PR, so this is the (ha) minimal set of basic linting changes.

@briehl briehl merged commit 808f85c into main Jun 11, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants