Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsonld dependency and update Jsdom #253

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

LaChope
Copy link
Collaborator

@LaChope LaChope commented Jan 22, 2024

Resolves #255

FYI, I followed this thread: jsdom/jsdom#2524 and in particular this post: jsdom/jsdom#2524 (comment)

@LaChope LaChope requested a review from blcham January 22, 2024 09:22
Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for s-forms-kbss ready!

Name Link
🔨 Latest commit 56e0289
🔍 Latest deploy log https://app.netlify.com/sites/s-forms-kbss/deploys/65afb22258c2630008205dd1
😎 Deploy Preview https://deploy-preview-253--s-forms-kbss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

jest-environment-jsdom.cjs Outdated Show resolved Hide resolved
src/model/FormGenerator.js Outdated Show resolved Hide resolved
src/model/FormGenerator.js Outdated Show resolved Hide resolved
@LaChope LaChope requested a review from blcham January 23, 2024 12:34
@blcham
Copy link
Collaborator

blcham commented Jan 23, 2024

@LaChope can you write ticket and connect it to this PR so we understand that it is workaround and we should now what to do next alternatively:

  • switch to something else than Jest because it is deprecated or ...

jest-environment-jsdom.cjs Show resolved Hide resolved
@blcham blcham merged commit 8d58f5b into master Jan 23, 2024
7 checks passed
@blcham blcham changed the title Update jsonld dependency and update Jest Update jsonld dependency and update Jsdom Jan 23, 2024
@LaChope LaChope deleted the update-jsonld-dependency branch January 26, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jsdom does not support TextEncoder and TextDecoder
2 participants