feat: implement rename api with new sema model (#890)

* feat: implement rename api

Signed-off-by: xiarui.xr <xiarui1994@gmail.com>

* minor: fix clippy errors

Signed-off-by: xiarui.xr <xiarui1994@gmail.com>

* fix select symbol bug, return range instead of symbol ref

Signed-off-by: xiarui.xr <xiarui1994@gmail.com>

* minor: use anyhow Result

Signed-off-by: xiarui.xr <xiarui1994@gmail.com>

---------

Signed-off-by: xiarui.xr <xiarui1994@gmail.com>

kclvm/ast/src/ast.rs

@@ -304,6 +304,14 @@ pub enum OverrideAction {
     CreateOrUpdate,
 }
 
+/// KCL API symbol selector Spec, eg: `pkgpath:path.to.field`
+#[derive(Serialize, Deserialize, Debug, Clone, PartialEq)]
+pub struct SymbolSelectorSpec {
+    pub pkg_root: String,
+    pub pkgpath: String,
+    pub field_path: String,
+}
+
 /// Program is the AST collection of all files of the running KCL program.
 #[derive(Serialize, Deserialize, Debug, Clone, Default, PartialEq)]
 pub struct Program {

kclvm/query/src/lib.rs

@@ -5,6 +5,7 @@
 //! AST, recursively modifying or deleting the values of the nodes in the AST.
 pub mod r#override;
 pub mod query;
+pub mod selector;
 
 #[cfg(test)]
 mod tests;

kclvm/query/src/selector.rs

@@ -0,0 +1,37 @@
+use super::util::{invalid_symbol_selector_spec_error, split_field_path};
+use anyhow::Result;
+use kclvm_ast::ast;
+
+/// Parse symbol selector string to symbol selector spec
+///
+/// # Examples
+///
+/// ```
+/// use kclvm_query::selector::parse_symbol_selector_spec;
+///
+/// if let Ok(spec) = parse_symbol_selector_spec("", "alice.age") {
+///     assert_eq!(spec.pkgpath, "".to_string());
+///     assert_eq!(spec.field_path, "alice.age".to_string());
+/// }
+/// ```
+pub fn parse_symbol_selector_spec(
+    pkg_root: &str,
+    symbol_path: &str,
+) -> Result<ast::SymbolSelectorSpec> {
+    if let Ok((pkgpath, field_path)) = split_field_path(symbol_path) {
+        Ok(ast::SymbolSelectorSpec {
+            pkg_root: pkg_root.to_string(),
+            pkgpath,
+            field_path,
+        })
+    } else {
+        Err(invalid_symbol_selector_spec_error(symbol_path))
+    }
+}
+
+#[test]
+fn test_symbol_path_selector() {
+    let spec = parse_symbol_selector_spec("", "pkg_name:alice.age").unwrap();
+    assert_eq!(spec.pkgpath, "pkg_name".to_string());
+    assert_eq!(spec.field_path, "alice.age".to_string());
+}

kclvm/query/src/util.rs

@@ -27,3 +27,12 @@ pub(crate) fn split_field_path(path: &str) -> Result<(String, String)> {
 pub(crate) fn invalid_spec_error(spec: &str) -> anyhow::Error {
     anyhow!("Invalid spec format '{}', expected <pkgpath>:<field_path>=<filed_value> or <pkgpath>:<field_path>-", spec)
 }
+
+/// Get the invalid symbol selector spec error message.
+#[inline]
+pub(crate) fn invalid_symbol_selector_spec_error(spec: &str) -> anyhow::Error {
+    anyhow!(
+        "Invalid spec format '{}', expected <pkgpath>:<field_path>",
+        spec
+    )
+}

kclvm/spec/gpyrpc/gpyrpc.proto

@@ -302,7 +302,7 @@ message KeyValuePair {
 message Rename_Args {
     string symbol_path = 1;               // the path to the target symbol to be renamed. The symbol path should conform to format: `<pkgpath>:<field_path>` When the pkgpath is '__main__', `<pkgpath>:` can be omitted.
     repeated string file_paths = 2;       // the paths to the source code files
-    string newName = 3;                   // the new name of the symbol
+    string new_name = 3;                   // the new name of the symbol
 }
 
 message Rename_Result {
@@ -317,7 +317,7 @@ message Rename_Result {
 message RenameCode_Args {
     string symbol_path = 1;               // the path to the target symbol to be renamed. The symbol path should conform to format: `<pkgpath>:<field_path>` When the pkgpath is '__main__', `<pkgpath>:` can be omitted.
     map<string, string> source_codes = 2; // the source code. a <filename>:<code> map
-    string newName = 3;                   // the new name of the symbol
+    string new_name = 3;                   // the new name of the symbol
 }
 
 message RenameCode_Result {

kclvm/tools/src/LSP/Cargo.toml

@@ -30,6 +30,7 @@ kclvm-ast = { path = "../../../ast" }
 kclvm-utils = { path = "../../../utils" }
 kclvm-version = { path = "../../../version" }
 compiler_base_session = { path = "../../../../compiler_base/session" }
+kclvm-query = {path = "../../../query"}
 
 lsp-server = { version = "0.6.0", default-features = false }
 anyhow = { version = "1.0", default-features = false, features = ["std"] }

kclvm/tools/src/LSP/src/lib.rs

@@ -13,6 +13,7 @@ mod hover;
 mod main_loop;
 mod notification;
 mod quick_fix;
+pub mod rename;
 mod request;
 mod state;
 #[cfg(test)]