Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Musl build for Alpine Linux #1770

Merged
merged 2 commits into from
Dec 3, 2024
Merged

feat: Musl build for Alpine Linux #1770

merged 2 commits into from
Dec 3, 2024

Conversation

Gmin2
Copy link
Contributor

@Gmin2 Gmin2 commented Dec 2, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references

  • N
  • Y

Fixes #1765

2. What is the scope of this PR (e.g. component or file name):

.github/workflows

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Musl build for Alpine Linux

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

No

Screenshot from 2024-12-02 20-19-55

@Gmin2
Copy link
Contributor Author

Gmin2 commented Dec 2, 2024

Also @Peefy can we use matrix strategy instead of having seperate files for each OS

Signed-off-by: utnim2 <mintugogoi567@gmail.com>
Signed-off-by: utnim2 <mintugogoi567@gmail.com>
@coveralls
Copy link
Collaborator

coveralls commented Dec 2, 2024

Pull Request Test Coverage Report for Build 12122393416

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.009%) to 70.939%

Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 1 66.67%
kclvm/sema/src/resolver/mod.rs 1 99.19%
kclvm/sema/src/core/symbol.rs 3 53.65%
Totals Coverage Status
Change from base Build 12068681818: -0.009%
Covered Lines: 52906
Relevant Lines: 74580

💛 - Coveralls

@Peefy Peefy merged commit 18caaca into kcl-lang:main Dec 3, 2024
14 checks passed
SkySingh04 pushed a commit to SkySingh04/kcl that referenced this pull request Dec 24, 2024
* musl build for Alpine Linux

Signed-off-by: utnim2 <mintugogoi567@gmail.com>

* fixed the path name

Signed-off-by: utnim2 <mintugogoi567@gmail.com>

---------

Signed-off-by: utnim2 <mintugogoi567@gmail.com>
Signed-off-by: Akash <akashsingh2210670@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support musl for Alpine Linux
3 participants