Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix func kcl_alloc. #1782

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix func kcl_alloc. #1782

merged 1 commit into from
Dec 17, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Dec 11, 2024

Init ptr value when alloc

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added bug Something isn't working wasm Issues or PRs related to kcl and wasm api Issues or PRs related to kcl rust native APIs and multi-lang APIs labels Dec 11, 2024
Signed-off-by: he1pa <18012015693@163.com>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12349662488

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 70.678%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/src/capi.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/src/capi.rs 1 0.0%
Totals Coverage Status
Change from base Build 12349353137: 0.001%
Covered Lines: 52773
Relevant Lines: 74667

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit 78346e0 into main Dec 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs bug Something isn't working wasm Issues or PRs related to kcl and wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants