-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add chars method for builtin str #1793
Conversation
4652478
to
1ff703c
Compare
Some lsp test failed about str std method. just re-run and update *.snap file |
cc @zong-zhe |
1ff703c
to
737ae01
Compare
Signed-off-by: Zejun Zhao <jelly.zhao.42@gmail.com>
737ae01
to
3fe5aa1
Compare
Signed-off-by: he1pa <18012015693@163.com>
Pull Request Test Coverage Report for Build 12653107375Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sorry for the long delay. I have no clue about the CI failure. I cannot reproduce it locally since the official dev container's configuration is different from the workflow machine and the test suite doesn't work well in the dev container. Furthermore, I didn't find a relevant doc about the |
Ok, I will complete this PR later, but not now. |
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
kclvm/runtime/src/
kclvm/runtime/src/value/
kclvm/runtime/src/builtin/
kclvm/tests/test_units/runtime/str/
test/grammar/builtins/str/
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
This PR adds a
chars
method for builtin str to return a list of the characters in the string.4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
Runtime test: kclvm/tests/test_units/runtime/str/
Grammar test: test/grammar/builtins/str/