Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: index signature str union ty check #1808

Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 4, 2025

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fixes #1804

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/resolver/config.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/schema/index_signature/fail_12/main.k

@Peefy Peefy requested review from He1pa and zong-zhe January 4, 2025 07:05
@Peefy Peefy added this to the v1.0 Release milestone Jan 4, 2025
@Peefy Peefy added resolver bug Something isn't working labels Jan 4, 2025
@Peefy Peefy self-assigned this Jan 4, 2025
Signed-off-by: Peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the fix-index-signature-str-union-ty-check branch from dd457ff to 4f786f6 Compare January 4, 2025 07:14
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12608537845

Details

  • 64 of 92 (69.57%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 70.711%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/config.rs 64 92 69.57%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/config.rs 1 83.52%
kclvm/sema/src/core/symbol.rs 3 53.5%
Totals Coverage Status
Change from base Build 12558826184: 0.02%
Covered Lines: 52849
Relevant Lines: 74739

💛 - Coveralls

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit dffaa67 into kcl-lang:main Jan 6, 2025
13 checks passed
@Peefy Peefy deleted the fix-index-signature-str-union-ty-check branch January 6, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolver
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Index signature schema key type with union of literals not evaluated
4 participants