Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix hidden global vars when merge in evaluator #1811

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jan 8, 2025

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/evaluator/src/lib.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

He1pa added 2 commits January 8, 2025 11:29
Signed-off-by: he1pa <18012015693@163.com>
Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa added bug Something isn't working evaluator labels Jan 8, 2025
Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa force-pushed the fix_hidden_global_vars branch from c8cfec8 to d5dc90d Compare January 8, 2025 06:25
Signed-off-by: he1pa <18012015693@163.com>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12665341717

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 70.682%

Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/advanced_resolver/node.rs 1 84.99%
kclvm/sema/src/core/symbol.rs 3 53.5%
kclvm/tools/src/LSP/src/state.rs 12 73.56%
Totals Coverage Status
Change from base Build 12654821010: -0.02%
Covered Lines: 52844
Relevant Lines: 74763

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit f368119 into main Jan 8, 2025
13 checks passed
@Peefy Peefy deleted the fix_hidden_global_vars branch January 9, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working evaluator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants