Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance evaluator func type_pack_and_check err msg #1822

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jan 14, 2025

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/evaluator/src/ty.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa added enhancement New feature or request error-handling Issues or PRs related to kcl error handling evaluator labels Jan 14, 2025
Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa force-pushed the enhance_type_pack_and_check_err_msg branch 2 times, most recently from 0746bb3 to d7ea17f Compare January 14, 2025 06:04
Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa force-pushed the enhance_type_pack_and_check_err_msg branch from d7ea17f to b011652 Compare January 14, 2025 06:08
Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa force-pushed the enhance_type_pack_and_check_err_msg branch from 9ed3d5e to 247295f Compare January 14, 2025 08:06
Signed-off-by: he1pa <18012015693@163.com>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12763979183

Details

  • 1 of 66 (1.52%) changed or added relevant lines in 2 files are covered.
  • 19 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.07%) to 70.48%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/evaluator/src/schema.rs 0 19 0.0%
kclvm/evaluator/src/ty.rs 1 47 2.13%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/advanced_resolver/node.rs 1 84.99%
kclvm/tools/src/LSP/src/request.rs 4 65.34%
kclvm/tools/src/LSP/src/state.rs 7 74.43%
kclvm/tools/src/LSP/src/dispatcher.rs 7 65.71%
Totals Coverage Status
Change from base Build 12759901294: -0.07%
Covered Lines: 52830
Relevant Lines: 74957

💛 - Coveralls

@Peefy Peefy merged commit 29266c0 into main Jan 14, 2025
12 of 13 checks passed
@Peefy Peefy deleted the enhance_type_pack_and_check_err_msg branch January 14, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request error-handling Issues or PRs related to kcl error handling evaluator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants