Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix builtin 'modpath()' returns empty #1824

Merged
merged 4 commits into from
Jan 14, 2025
Merged

fix: fix builtin 'modpath()' returns empty #1824

merged 4 commits into from
Jan 14, 2025

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1799

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added the bug Something isn't working label Jan 14, 2025
@zong-zhe zong-zhe added this to the v1.0 Release milestone Jan 14, 2025
@zong-zhe zong-zhe requested a review from He1pa January 14, 2025 08:16
@zong-zhe zong-zhe self-assigned this Jan 14, 2025
Signed-off-by: zongz <zongzhe1024@163.com>
@coveralls
Copy link
Collaborator

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12764387554

Details

  • 26 of 27 (96.3%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 70.58%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/entry.rs 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 1 66.14%
kclvm/sema/src/advanced_resolver/node.rs 1 84.99%
Totals Coverage Status
Change from base Build 12759901294: 0.03%
Covered Lines: 52875
Relevant Lines: 74915

💛 - Coveralls

Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
@Peefy Peefy merged commit 829b262 into main Jan 14, 2025
13 checks passed
@Peefy Peefy deleted the fix-buildin-modpath branch January 14, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: builtin modpath() returns a wrong path
3 participants