Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable empty list feature #876

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 14, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat: disable empty list feature instead of ignore empty list output

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runtime/src/api/kclvm.rs
  • kclvm/runtime/src/value/val_plan.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy force-pushed the feat-disable-empty-list branch from f16f763 to aed9ce8 Compare November 14, 2023 08:50
@coveralls
Copy link
Collaborator

coveralls commented Nov 14, 2023

Pull Request Test Coverage Report for Build 6862142460

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-17.3%) to 70.52%

Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6861867573: -17.3%
Covered Lines: 40188
Relevant Lines: 56988

💛 - Coveralls

@Peefy Peefy force-pushed the feat-disable-empty-list branch from aed9ce8 to 289a5e7 Compare November 14, 2023 09:49
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy force-pushed the feat-disable-empty-list branch from 289a5e7 to eb69957 Compare November 14, 2023 10:12
@Peefy Peefy changed the title [WIP] feat: disable empty list feature feat: disable empty list feature Nov 14, 2023
@Peefy Peefy merged commit 3f840da into kcl-lang:main Nov 14, 2023
10 of 11 checks passed
@Peefy Peefy deleted the feat-disable-empty-list branch November 14, 2023 10:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants