Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch: migrate lsp schema attr completion to new sema model #883

Closed
wants to merge 1 commit into from

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Nov 15, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

lsp/completion.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

migrate lsp schema attr completion to new sema model

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: he1pa <18012015693@163.com>
@He1pa He1pa added the lsp label Nov 15, 2023
@He1pa He1pa added this to the v0.7.0 Release milestone Nov 15, 2023
@He1pa He1pa self-assigned this Nov 15, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6875129955

  • 25 of 29 (86.21%) changed or added relevant lines in 1 file are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-15.7%) to 72.153%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/completion.rs 25 29 86.21%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6874683839: -15.7%
Covered Lines: 41228
Relevant Lines: 57140

💛 - Coveralls

documentation: attr.doc.clone(),
kind: Some(KCLCompletionItemKind::SchemaAttr),
let mut items = IndexSet::new();
if let Some((_, schema_expr)) = is_in_schema_expr(program, pos) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this function is_in_schema_expr with the new semantic and how to ensure the correctness of the function.

@He1pa He1pa closed this Nov 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

3 participants