Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support incremental resolver #884

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

NeverRaR
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #866

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/
kclvm/ast

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other
    feat: support incremental resolver

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@NeverRaR NeverRaR force-pushed the dev/boying/resolver branch from 87600e8 to e82a2fb Compare November 15, 2023 10:05
@coveralls
Copy link
Collaborator

coveralls commented Nov 15, 2023

Pull Request Test Coverage Report for Build 6885357805

  • 145 of 233 (62.23%) changed or added relevant lines in 11 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-15.7%) to 72.096%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/advanced_resolver/mod.rs 3 4 75.0%
kclvm/sema/src/resolver/cache.rs 56 143 39.16%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6874683839: -15.7%
Covered Lines: 41352
Relevant Lines: 57357

💛 - Coveralls

@Peefy Peefy added the resolver label Nov 15, 2023
@Peefy Peefy added this to the v0.7.0 Release milestone Nov 15, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kclvm/sema/src/resolver/cache.rs Show resolved Hide resolved
kclvm/sema/src/resolver/cache.rs Outdated Show resolved Hide resolved
Signed-off-by: never <chenxiangfei.cxf@antgroup.com>
@NeverRaR NeverRaR force-pushed the dev/boying/resolver branch from e82a2fb to d5ef2b1 Compare November 16, 2023 02:02
@Peefy Peefy merged commit 90b92cb into kcl-lang:main Nov 16, 2023
9 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

3 participants