Enoder to return nil instead of an empty data if encoding fails

kean · Apr 21, 2024 · 7d7efed · 7d7efed
1 parent cd3e07e
commit 7d7efed
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/Sources/Nuke/Encoding/ImageEncoders+ImageIO.swift b/Sources/Nuke/Encoding/ImageEncoders+ImageIO.swift
@@ -59,7 +59,9 @@ extension ImageEncoders {
                     return nil
             }
             CGImageDestinationAddImage(destination, source, options as CFDictionary)
-            CGImageDestinationFinalize(destination)
+            guard CGImageDestinationFinalize(destination) else {
+                return nil
+            }
             return data as Data
         }
     }

diff --git a/Sources/Nuke/Tasks/TaskLoadImage.swift b/Sources/Nuke/Tasks/TaskLoadImage.swift
@@ -162,7 +162,7 @@ final class TaskLoadImage: ImagePipelineTask<ImageResponse> {
             }
             guard let data = encodedData else { return }
             pipeline.delegate.willCache(data: data, image: response.container, for: request, pipeline: pipeline) {
-                guard let data = $0 else { return }
+                guard let data = $0, !data.isEmpty else { return }
                 // Important! Storing directly ignoring `ImageRequest.Options`.
                 dataCache.storeData(data, for: key) // This is instant, writes are async
             }