Fix typos in additive_attention #20711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I observed a few typos in additive_attention
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20711 +/- ##
==========================================
+ Coverage 81.93% 82.22% +0.29%
==========================================
Files 548 561 +13
Lines 51190 52955 +1765
Branches 7912 8205 +293
==========================================
+ Hits 41942 43544 +1602
- Misses 7310 7373 +63
- Partials 1938 2038 +100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gbaned
approved these changes
Jan 7, 2025
google-ml-butler
bot
added
kokoro:force-run
ready to pull
| @@ -33,7 +33,7 @@ class AdditiveAttention(Attention): | |||
| - `query`: Query tensor of shape `(batch_size, Tq, dim)`. | |||
| - `value`: Value tensor of shape `(batch_size, Tv, dim)`. | |||
| - `key`: Optional key tensor of shape `(batch_size, Tv, dim)`. If | |||
| not given, will use `value` for both `key` and `value`, which is | |||
| not given, will use the`value` for both `key` and `value`, which is | |||
There was a problem hiding this comment.
The line you modified is now 83 characters long, which is why the code format check didn't pass. The maximum allowed length is 80.
You can rewrite it to:
Suggested change
| not given, will use the`value` for both `key` and `value`, which is | |
| not given, will use the`value` for both `key` and `value`, | |
| which is the most common case. |
Modified
google-ml-butler
bot
removed
the
ready to pull
gbaned
approved these changes
Mar 10, 2025
google-ml-butler
bot
added
kokoro:force-run
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed a few typos in additive_attention