-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenVINO Backend] Support np.diag #20967
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20967 +/- ##
=======================================
Coverage 82.42% 82.43%
=======================================
Files 561 561
Lines 53226 53247 +21
Branches 8244 8250 +6
=======================================
+ Hits 43871 43892 +21
- Misses 7338 7344 +6
+ Partials 2017 2011 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm not sure why tests for |
@rkazants Please review whenever you can can. Thank you |
Hi, @rkazants, The current NumpyOneInputOpsCorrectnessTest::test_diag doesn't cover all the edge cases, for example, where k = 3, for a rank 2 array, where the expected output is an empty array. Should I add those tests as well? |
@rkazants bump |
CC: @rkazants