Update conftest.py #21003
Open
Update conftest.py #21003
+29
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### **🌟 Summary of Fixes** | **Change** | **Reason** | |------------|-----------| | Graceful handling of missing `torch` | Prevents `NameError` if `torch` is referenced later | | Safe handling of missing `excluded_concrete_tests.txt` | Prevents `FileNotFoundError` and skips only non-empty lines | | Improved backend checking | More readable and easier to maintain | | Encapsulated `skip_if_backend()` function | Makes skipping tests more reusable and cleaner | ---
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21003 +/- ##
=======================================
Coverage 82.43% 82.43%
=======================================
Files 562 562
Lines 53401 53401
Branches 8274 8274
=======================================
Hits 44020 44020
Misses 7361 7361
Partials 2020 2020
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 Summary of Fixes
torchNameErroriftorchis referenced laterexcluded_concrete_tests.txtFileNotFoundErrorand skips only non-empty linesskip_if_backend()function