Skip to content

Commit

Permalink
feat: drop issues section from log viewer
Browse files Browse the repository at this point in the history
- issues section remove from the context of builds and tests details
  only

Close #993
  • Loading branch information
Francisco2002 committed Feb 26, 2025
1 parent fbc783e commit 5326832
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 6 deletions.
1 change: 1 addition & 0 deletions dashboard/src/components/BuildDetails/BuildDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ const BuildDetails = ({
<LogOrJsonSheetContent
type={sheetType}
jsonContent={jsonContent}
hideIssueSection
logUrl={data?.log_url}
logExcerpt={data?.log_excerpt}
/>
Expand Down
17 changes: 11 additions & 6 deletions dashboard/src/components/Sheet/LogOrJsonSheetContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ interface ILogSheet {
navigationLogsActions?: TNavigationLogActions;
currentLinkProps?: LinkProps;
issues?: TIssue[];
hideIssueSection?: boolean;
status?: UseQueryResult['status'];
error?: UseQueryResult['error'];
}
Expand All @@ -43,6 +44,7 @@ export const LogOrJsonSheetContent = ({
navigationLogsActions,
currentLinkProps,
issues,
hideIssueSection,
status,
error,
}: ILogSheet): JSX.Element => {
Expand All @@ -66,12 +68,15 @@ export const LogOrJsonSheetContent = ({
logExcerpt={logExcerpt}
isLoading={navigationLogsActions?.isLoading}
/>
<IssueSection
data={issues}
status={status ?? 'success'}
error={error?.message}
variant="warning"
/>

{!hideIssueSection && (
<IssueSection
data={issues}
status={status ?? 'success'}
error={error?.message}
variant="warning"
/>
)}
</>
) : (
<ReactJsonView
Expand Down
1 change: 1 addition & 0 deletions dashboard/src/components/TestDetails/TestDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ const TestDetails = ({ breadcrumb }: TestsDetailsProps): JSX.Element => {
type={sheetType}
jsonContent={jsonContent}
logUrl={data?.log_url}
hideIssueSection
logExcerpt={data?.log_excerpt}
/>
</Sheet>
Expand Down

0 comments on commit 5326832

Please sign in to comment.