-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: log viewer query param #1006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, working well
(open: boolean) => | ||
navigate({ search: s => ({ ...s, logOpen: open }), state: s => s }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
(open: boolean) => | |
navigate({ search: s => ({ ...s, logOpen: open }), state: s => s }), | |
(isOpen: boolean) => | |
navigate({ search: s => ({ ...s, logOpen: isOpen }), state: s => s }), |
(open: boolean) => | ||
navigate({ search: s => ({ ...s, logOpen: open }), state: s => s }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto isOpen
db9a567
to
05ff183
Compare
Add a boolean query parameter
logOpen
to both/build/$buildId
and/test/$testId
that saves the open state of the log viewer in those pages and open it automatically when the link is open with the parameter set to trueCloses #994
How to test
false