Feat: issue listing changes #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilx
force-pushed
the
feat/issues-listing-changes
branch
from
a094245 to
8c1fede
Compare
Francisco2002
force-pushed
the
feat/issues-listing-changes
branch
from
8c1fede to
e0f8b3d
Compare
Comment on lines
87
to
91
| return params ? ( | ||
| <FormattedMessage id="routes.issueDetails" /> | ||
| ) : ( | ||
| <FormattedMessage id="routes.issueMonitor" /> | ||
| ); |
There was a problem hiding this comment.
Why do you have this conditional if the URL for issue details is also /issues/?
There was a problem hiding this comment.
This was used to differentiate the Title of issues listing and issues details. With the modification that Padovan requests, this will be changed.
dashboard/src/types/general.ts
Outdated
| @@ -361,6 +361,7 @@ export const getTargetFilter = ( | |||
| export enum RedirectFrom { | |||
| Tree = 'tree', | |||
| Hardware = 'hardware', | |||
| Issue = 'issues', | |||
There was a problem hiding this comment.
Add it in plural directly, so there is no confusion of the routes
padovan
requested changes
Mar 7, 2025
| @@ -47,7 +47,7 @@ const IssueSection = ({ | |||
| <Link | |||
| key={issue.id + issue.version} | |||
| className="mb-16 flex not-last:mb-2 not-last:border-b not-last:pb-2" | |||
| to="/issue/$issueId" | |||
| to="/issues/$issueId" | |||
There was a problem hiding this comment.
Nack! individual issues URL stay as is. Only the top level one is changing to issues. We have sent links to dashboard issues all over the place. So we can't change that anymore.
Francisco2002
force-pushed
the
feat/issues-listing-changes
branch
2 times, most recently
from
56c357f to
a1a2de3
Compare
There was a problem hiding this comment.
There's no need for this component, please reuse TooltipIcon
Francisco2002
force-pushed
the
feat/issues-listing-changes
branch
from
a1a2de3 to
d92c46a
Compare
- remove version from listing - add tolltip to explain culprit in listing and details pages Part of #1014
Francisco2002
force-pushed
the
feat/issues-listing-changes
branch
from
d92c46a to
724ffbe
Compare
MarceloRobert
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements of issues context
Close #1014