Feat: add discord webhook helpers #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a quick correction, is seems that you have implemented code for both failed builds with tests but also for trees with no builds, tests or boots, or am I overlooking something? |
MarceloRobert
force-pushed
the
feat/prepare-discord-webhook
branch
from
92ee98d to
beb769a
Compare
WilsonNet
reviewed
Mar 7, 2025
| @@ -26,6 +29,13 @@ def get(self, request, build_id: str) -> Response: | |||
| status=HTTPStatus.OK, | |||
| ) | |||
|
|
|||
| if result[0]["build__valid"] is False: | |||
There was a problem hiding this comment.
check if result[0] exists
There was a problem hiding this comment.
I think that the if before (if not result) should be enough, shouldn't it?
Python 3.12.7 (main, Nov 18 2024, 15:03:02) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> a = []
>>> not a
True
>>> a.append(1)
>>> not a
FalseThere was a problem hiding this comment.
but I'd still do
Suggested change
| if result[0]["build__valid"] is False: | |
| if result[0].get("build__valid") is False: |
just to be sure
MarceloRobert
force-pushed
the
feat/prepare-discord-webhook
branch
2 times, most recently
from
b982a81 to
15ce9bf
Compare
WilsonNet
reviewed
Mar 10, 2025
| @@ -45,6 +45,7 @@ services: | |||
| - DB_DEFAULT_USER=${DB_DEFAULT_USER:-kernelci} | |||
| - DJANGO_SECRET_KEY=${DJANGO_SECRET_KEY} | |||
| - DEBUG=False | |||
| - DISCORD_WEBHOOK_URL=${DISCORD_WEBHOOK_URL} | |||
There was a problem hiding this comment.
Add the env description to the backend README file
WilsonNet
approved these changes
Mar 10, 2025
MarceloRobert
force-pushed
the
feat/prepare-discord-webhook
branch
from
15ce9bf to
3c565cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds helper functions to send messages using a discord webhook
How to test
Get a discord webhook url, by going to discord server settings, creating or viewing a webhook and copying its URL
Set the environment variable
DISCORD_WEBHOOK_URLwith the url of your webhook (should look something likehttps://discord.com/api/webhooks/<id>/<webhook_id>)Currently there is only a notification for failed builds that had tests, such as this localhost buildDetails
Closes #1027