Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

results: add --arch filter #130

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

CamilaAlvarez
Copy link
Contributor

Adds --arch to results options and parameter filter_architecture to api params in dashboard_fetch_summary, dashboard_fetch_builds, dashboard_fetch_boots, and dashboard_fetch_tests.

@aliceinwire
Copy link
Member

aliceinwire commented Mar 5, 2025

Please read the contributing guideline here

looks like black is complaining about format issue

@padovan
Copy link
Contributor

padovan commented Mar 5, 2025

This is great. Thanks for the contribution. Beyond the format issue, I'd also add a mention about the new arg option in the documentation.

Adds --arch to results options and  parameter filter_architecture to api params in dashboard_fetch_summary, dashboard_fetch_builds,
dashboard_fetch_boots, and dashboard_fetch_tests.

Signed-off-by: Camila Alvarez <cam.alvarez.i@gmail.com>
Signed-off-by: Camila Alvarez <cam.alvarez.i@gmail.com>
@CamilaAlvarez
Copy link
Contributor Author

Hello @aliceinwire @padovan! I fixed the format and added the option to the documentation

@aliceinwire
Copy link
Member

thanks

@aliceinwire aliceinwire merged commit 52beef9 into kernelci:main Mar 6, 2025
5 checks passed
@CamilaAlvarez CamilaAlvarez deleted the results-arch-filter branch March 7, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants