Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker/api: pin PyYAML version to 5.3.1 #306

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

gctucker
Copy link
Contributor

The version of PyYAML was not being specified and newer releases rely on more recent dependencies which cascade into basically updating FastAPI and some parts of the code accordingly. While doing this would make sense to keep the API codebase up-to-date, pin down the PyYAML version to 5.3.1 for now in requirements.txt so we avoid the whole issue in the short term.

Fixes: #303

The version of PyYAML was not being specified and newer releases rely
on more recent dependencies which cascade into basically updating
FastAPI and some parts of the code accordingly.  While doing this
would make sense to keep the API codebase up-to-date, pin down the
PyYAML version to 5.3.1 for now in requirements.txt so we avoid the
whole issue in the short term.

Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
@gctucker
Copy link
Contributor Author

Essentially, the pyyaml package just depends loosely on cython without specifying a version:
https://github.com/yaml/pyyaml/blob/master/pyproject.toml

[build-system]
requires = ["setuptools", "wheel", "Cython"]
build-backend = "setuptools.build_meta"

In this instance, cython got upgraded implicitly and that required also a cascading upgrade of PyYAML, Pydantic and FastAPI with some code changes as per #305 (which pins down pydantic to simplify things half-way through).

@JenySadadia JenySadadia added this pull request to the merge queue Jul 20, 2023
Merged via the queue into kernelci:main with commit 473bd7b Jul 20, 2023
@gctucker gctucker deleted the pyyaml-5.3.1 branch July 20, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to build API Docker image with Python 3.10
2 participants