Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose.yaml: Update API to use docker image #468

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

nuclearcat
Copy link
Member

Instead of doing local build - use docker image from registry.

@nuclearcat nuclearcat force-pushed the add-registry-docker branch 3 times, most recently from 2c5dc88 to a4b6976 Compare February 7, 2024 16:29
@pawiecz
Copy link
Contributor

pawiecz commented Feb 8, 2024

I believe having a docker-compose doing a local build could still be useful for further development.

Do you think the main docker-compose.yml would be more frequently used for sample deployments and the one with adjustments for local builds should be renamed to e.g. docker-compose-dev.yml or would the development purposes be the main use case and there should be docker-compose-production.yml with image pulled from registry?

@nuclearcat
Copy link
Member Author

current -dev is broken, this is what caused me to use docker image. But definitely i can rename old one to -dev and we can fix it for local development.

@pawiecz
Copy link
Contributor

pawiecz commented Feb 20, 2024

current -dev is broken, this is what caused me to use docker image.

I'm a bit confused on what exactly was broken but it might not be relevant anymore.

But definitely i can rename old one to -dev and we can fix it for local development.

Sure, let's keep them both (having the one with images from the registry as the default one). Later we could align them to keep only necessary overrides in the -dev (and call them like on staging).

@pawiecz
Copy link
Contributor

pawiecz commented Feb 20, 2024

Unit test were out-of-sync with current models in kernelci-core, hence CI failure. It should be all fine once this branch is rebased on current main.

Copy link
Collaborator

@JenySadadia JenySadadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK locally.

@JenySadadia
Copy link
Collaborator

@nuclearcat Could you please rebase the PR? Hopefully, that would fix the unit tests.

Instead of doing local build - use docker image from registry.

Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
@nuclearcat
Copy link
Member Author

Done, i think it can be merged?

@JenySadadia
Copy link
Collaborator

Done, i think it can be merged?

Yes, thanks.

@JenySadadia JenySadadia added this pull request to the merge queue Feb 27, 2024
Merged via the queue into kernelci:main with commit 9a569d6 Feb 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants