-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-compose.yaml: Update API to use docker image #468
Conversation
2c5dc88
to
a4b6976
Compare
I believe having a docker-compose doing a local build could still be useful for further development. Do you think the main |
current -dev is broken, this is what caused me to use docker image. But definitely i can rename old one to -dev and we can fix it for local development. |
I'm a bit confused on what exactly was broken but it might not be relevant anymore.
Sure, let's keep them both (having the one with images from the registry as the default one). Later we could align them to keep only necessary overrides in the |
Unit test were out-of-sync with current models in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK locally.
@nuclearcat Could you please rebase the PR? Hopefully, that would fix the unit tests. |
Instead of doing local build - use docker image from registry. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
a4b6976
to
722164d
Compare
Done, i think it can be merged? |
Yes, thanks. |
Instead of doing local build - use docker image from registry.