Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernelci.api: upgrade pydantic version #2710

Merged
merged 1 commit into from
Oct 24, 2024
Merged

kernelci.api: upgrade pydantic version #2710

merged 1 commit into from
Oct 24, 2024

Conversation

JenySadadia
Copy link
Collaborator

Enable pydantic v2 as API now supports it.

@JenySadadia JenySadadia added the staging-skip Don't test automatically on staging.kernelci.org label Oct 15, 2024
@JenySadadia JenySadadia removed the staging-skip Don't test automatically on staging.kernelci.org label Oct 16, 2024
@nuclearcat nuclearcat added the staging-skip Don't test automatically on staging.kernelci.org label Oct 16, 2024
@JenySadadia JenySadadia mentioned this pull request Oct 17, 2024
Merged
@JenySadadia JenySadadia removed the staging-skip Don't test automatically on staging.kernelci.org label Oct 17, 2024
@nuclearcat nuclearcat added the staging-skip Don't test automatically on staging.kernelci.org label Oct 18, 2024
@JenySadadia JenySadadia force-pushed the upgrade-pydantic branch 3 times, most recently from 11b7833 to 1b2d399 Compare October 18, 2024 13:34
@JenySadadia JenySadadia removed the staging-skip Don't test automatically on staging.kernelci.org label Oct 22, 2024
@JenySadadia JenySadadia marked this pull request as ready for review October 22, 2024 05:01
kernelci.api: upgrade pydantic version
bae3ece 
Enable pydantic v2 as API now supports it.

Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
@JenySadadia
Copy link
Collaborator Author

Fixed the error by implementing __get_pydantic_core_schema__ in PyObjectId class.

nuclearcat
nuclearcat approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nuclearcat nuclearcat added this pull request to the merge queue Oct 24, 2024
Merged via the queue into kernelci:main with commit 5345aed Oct 24, 2024
4 checks passed
@JenySadadia JenySadadia deleted the upgrade-pydantic branch October 24, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearcat nuclearcat nuclearcat approved these changes

@pawiecz pawiecz Awaiting requested review from pawiecz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JenySadadia @nuclearcat