Use dynamic branch triggers #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch slightly modifies existing patch URL validator. This function will be later moved to other Pipeline package and reused for triggering Maestro events based on dynamic kernel tree branches' names. Modified URL validator uses HEAD request instead of GET to just check resource availability - its content won't be used in the validation funtion so there's no need to download it. Signed-off-by: Paweł Wieczorek <pawiecz@collabora.com>
|
It looks like this does the job. I guess we try it in staging? |
padovan
approved these changes
Feb 14, 2025
This patch extracts function from "lava_callback" to keep it in a more generic package. In future it might be moved to e.g. "helpers" one but for now base Service will do. Signed-off-by: Paweł Wieczorek <pawiecz@collabora.com>
pawiecz
force-pushed
the
use-dynamic-branch-triggers
branch
from
164d9c1 to
7ba3900
Compare
NIPA [0] system doesn't use static branch names that could be added to the Pipeline config. This patch adds support to use an URL of a resource that contains dynamically updated branch names which will trigger Maestro events. This patch doesn't affect static Pipeline configuration. [0] https://github.com/linux-netdev/nipa Signed-off-by: Paweł Wieczorek <pawiecz@collabora.com>
…anches Signed-off-by: Paweł Wieczorek <pawiecz@collabora.com>
Signed-off-by: Paweł Wieczorek <pawiecz@collabora.com>
pawiecz
force-pushed
the
use-dynamic-branch-triggers
branch
from
7ba3900 to
6de88fc
Compare
Tarball service searches through the build configs for exact matches of tree and branch combinations. It won't find any on dynamically defined branches from external resource. This patch allows overriding branch from build config using value from event that triggered Tarball service. This change should be considered as a tech debt and replaced with a long-term solution. Signed-off-by: Paweł Wieczorek <pawiecz@collabora.com>
pawiecz
force-pushed
the
use-dynamic-branch-triggers
branch
from
1bd86ff to
60fc952
Compare
Function "find_tree" verifies tree existence in the Pipeline config but branch for "/checkout" request is taken from user's input. This patch uses less strict check to allow checkouts from branches absent in the static Pipeline config. Signed-off-by: Paweł Wieczorek <pawiecz@collabora.com>
pawiecz
force-pushed
the
use-dynamic-branch-triggers
branch
from
60fc952 to
99d78cb
Compare
|
Two patches added after initial review allow triggering custom kci-dev uses the same endpoint so it should work fine as well |
padovan
reviewed
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series adds support for dynamically updated branch names in the Pipeline config. It's required for NIPA system integration.
Please see also the details descriptions in specific patches.