Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/trigger: fix duplicate checkout node creations #390

Merged

Conversation

JenySadadia
Copy link
Collaborator

Fix multiple checkout node creation with the same revision commit. Update logic to check existing checkout node for specific commit as per Node schema changes.

Fix multiple checkout node creation with the same revision
commit. Update logic to check existing `checkout` node
for specific commit as per `Node` schema changes.

Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
@JenySadadia JenySadadia force-pushed the fix-duplicate-revision-commit-nodes branch from 77c018e to cda2ff5 Compare January 19, 2024 10:47
@JenySadadia
Copy link
Collaborator Author

Tested OK on staging:

today at 10:41:5701/23/2024 05:11:57 AM UTC [INFO] Existing revision                kernelci_staging-mainline        6d4e40ac30ff4d98055882972cdf051e92c0d160
today at 10:41:5801/23/2024 05:11:58 AM UTC [INFO] Existing revision                kernelci_staging-next            dae1a9f9c6ea96934f6b991a3a7816d7b950d2e9
today at 10:41:5901/23/2024 05:11:59 AM UTC [INFO] Existing revision                kernelci_staging-stable          bf2b6a8744961b114f654fa9d582e973a9c0d070
today at 10:41:5901/23/2024 05:11:59 AM UTC [INFO] Existing revision                mainline                         7ed2632ec7d72e926b9e8bcc9ad1bb0cd37274bf
today at 10:41:5901/23/2024 05:11:59 AM UTC [INFO] Sleeping for 3600s

Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@nuclearcat nuclearcat added this pull request to the merge queue Jan 23, 2024
Merged via the queue into kernelci:main with commit 1b39a36 Jan 23, 2024
3 checks passed
@JenySadadia JenySadadia deleted the fix-duplicate-revision-commit-nodes branch January 23, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants