Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial implementation for Tast tests #418

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

a-wai
Copy link
Contributor

@a-wai a-wai commented Feb 7, 2024

No description provided.

@a-wai a-wai requested review from pawiecz and nuclearcat February 8, 2024 10:42
@nuclearcat nuclearcat added staging-skip Don't test automatically on staging.kernelci.org and removed staging-skip Don't test automatically on staging.kernelci.org labels Feb 9, 2024
@a-wai a-wai force-pushed the add-basic-tast branch 4 times, most recently from 52818f6 to 9eed82b Compare February 12, 2024 15:20
@a-wai a-wai removed the staging-skip Don't test automatically on staging.kernelci.org label Feb 13, 2024
Changes in `kernelci-core` now require templates generating LAVA jobs to
set the `test_method` variable so the proper test template can be
included in the generated job definition.

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
This template ensures the `test_method` variable is set accordingly, and
defines the `kernel_url`, `modules_url`, `dtb_url` and `nfsroot`
variables in order to use the proper items for booting into ChromeOS.

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
Using `allnoconfig` as the defconfig for those builds creates an
unbootable kernel, we should instead use the chromeos-specific fragment
as the base defconfig in order to generate an actually bootable kernel.

Moreover, don't hardcode the kernel revision in the defconfig name but
rather make it an f-string to be processed at job generation time.

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
@a-wai a-wai force-pushed the add-basic-tast branch 2 times, most recently from 94738fe to 97c4576 Compare February 15, 2024 13:36
@a-wai a-wai marked this pull request as ready for review February 15, 2024 13:38
@a-wai
Copy link
Contributor Author

a-wai commented Feb 15, 2024

Marking as ready as it was successfully tested on puff:

Dropping the actual tast test job so it can be worked on in a separate PR: #435

@nuclearcat nuclearcat added this pull request to the merge queue Feb 15, 2024
Merged via the queue into kernelci:main with commit f00b5dd Feb 15, 2024
3 checks passed
@a-wai a-wai deleted the add-basic-tast branch February 16, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants