timeout.py: Fix result, error_code for nodes that timed out #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearcat
force-pushed
the
add-result-error
branch
3 times, most recently
from
eb6234c to
9622ea0
Compare
JenySadadia
reviewed
Feb 9, 2024
nuclearcat
force-pushed
the
add-result-error
branch
from
6510f6a to
b442e3e
Compare
JenySadadia
reviewed
Feb 12, 2024
nuclearcat
force-pushed
the
add-result-error
branch
3 times, most recently
from
f1a4593 to
df22a4e
Compare
In case of LAVA, for example, if task was not submitted, or callback didn't reached, timeout service will close such node after while, but in obscure state: job_id exist, state is done, and result is nul. Let's set result as 'incomplete', fill error_code for better clarity. Probably fixes: kernelci/kernelci-api#470 Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
force-pushed
the
add-result-error
branch
from
df22a4e to
94f4dbc
Compare
JenySadadia
approved these changes
Feb 14, 2024
|
Tested OK on staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of LAVA, for example, if task was not submitted properly, or callback didn't reached, timeout service will close such node after while, but in obscure state: job_id exist, state is done, and result is nul. Let's set result as 'incomplete', fill error_code for better clarity.
Probably fixes: kernelci/kernelci-api#470