lava_callback.py: Handle failed jobs properly #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearcat
force-pushed
the
fix-lava-callback-bad-jobs
branch
from
24b996b to
cd5d35b
Compare
As mentioned in kernelci/kernelci-api#474, even if job failed, node still registered as pass, and trying to upload non-existing log file. Fix that, if job is not completed, set node status to incomplete and do not upload log file. Fixes: kernelci/kernelci-api#474 Depends on: kernelci/kernelci-core#2363 Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
force-pushed
the
fix-lava-callback-bad-jobs
branch
from
cd5d35b to
c0ce87f
Compare
|
Example of incomplete job: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in kernelci/kernelci-api#474, even if job failed, node still registered as pass, and trying to upload non-existing log file. Fix that, if job is not completed, set node status to incomplete and do not upload log file.
Fixes: kernelci/kernelci-api#474
Depends on: kernelci/kernelci-core#2363