-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: chromeos: add codec-related Tast tests #452
Conversation
25c9be1
to
d4e1db0
Compare
Adding
|
d4e1db0
to
8cfea2a
Compare
Fixed, sorry about that! |
@laura-nao Thanks for the review! One thing I was wondering: could we make vp9-group{1,2,3,4} a single job? It seems those should always run on the same platforms, unless you anticipate changes to happen there? We might also group vp9-level5 and vp9-svc a single job named |
695271d
to
c304dd4
Compare
@a-wai when I first added these tests in the legacy system, I noticed that a job running all vp9 tests would exceed 10 minutes so I opted for splitting them into groups. I'm not against combining them into a single suite (especially if it makes more sense from a resource usage pov), it will just take more time to execute and I'm not sure if the best practice of avoiding jobs >10min still stands for the new system or not. |
@laura-nao well we already have multiple Tast jobs >10mins, so I'd say this "rule" at least has a few exceptions, Tast tests being one of them. I'll proceed with grouping tests as I suggested then, if it doesn't work we can always revert that later. |
Those were left aside for the initial implementation, we can bring them back now we're confident Tast tests generally run as expected on the new system. Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
c304dd4
to
f9771d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests being run, might be failing now, but this might be next step fixing minor details
https://staging.kernelci.org:9000/viewer?search=parent%3D65eac74577d9d88b36edbb6b
Those were left aside for the initial implementation, we can bring them back now we're confident Tast tests generally run as expected on the new system.
Based on kernelci/kernelci-core#2302