Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: chromeos: add codec-related Tast tests #452

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

a-wai
Copy link
Contributor

@a-wai a-wai commented Mar 1, 2024

Those were left aside for the initial implementation, we can bring them back now we're confident Tast tests generally run as expected on the new system.

Based on kernelci/kernelci-core#2302

@a-wai a-wai requested review from nuclearcat and laura-nao March 1, 2024 14:52
@a-wai a-wai force-pushed the add-tast-codec-tests branch from 25c9be1 to d4e1db0 Compare March 1, 2024 15:30
@JenySadadia
Copy link
Collaborator

Adding staging-skip due to below errors on staging:

kernelci-pipeline-trigger | Traceback (most recent call last):
kernelci-pipeline-trigger |   File "/home/kernelci/./pipeline/trigger.py", line 163, in <module>
kernelci-pipeline-trigger |     configs = kernelci.config.load(yaml_configs)
kernelci-pipeline-trigger |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/config/__init__.py", line 191, in load
kernelci-pipeline-trigger |     data = load_yaml(config_paths)
kernelci-pipeline-trigger |            ^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/config/__init__.py", line 149, in load_yaml
kernelci-pipeline-trigger |     data = load_single_yaml(path)
kernelci-pipeline-trigger |            ^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/config/__init__.py", line 86, in load_single_yaml
kernelci-pipeline-trigger |     for _, data in iterate_yaml_files(config_path):
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/config/__init__.py", line 30, in iterate_yaml_files
kernelci-pipeline-trigger |     data = yaml.safe_load(yaml_file)
kernelci-pipeline-trigger |            ^^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/yaml/__init__.py", line 125, in safe_load
kernelci-pipeline-trigger |     return load(stream, SafeLoader)
kernelci-pipeline-trigger |            ^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/yaml/__init__.py", line 81, in load
kernelci-pipeline-trigger |     return loader.get_single_data()
kernelci-pipeline-trigger |            ^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/yaml/constructor.py", line 49, in get_single_data
kernelci-pipeline-trigger |     node = self.get_single_node()
kernelci-pipeline-trigger |            ^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 36, in get_single_node
kernelci-pipeline-trigger |     document = self.compose_document()
kernelci-pipeline-trigger |                ^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 55, in compose_document
kernelci-pipeline-trigger |     node = self.compose_node(None, None)
kernelci-pipeline-trigger |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 84, in compose_node
kernelci-pipeline-trigger |     node = self.compose_mapping_node(anchor)
kernelci-pipeline-trigger |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 133, in compose_mapping_node
kernelci-pipeline-trigger |     item_value = self.compose_node(node, item_key)
kernelci-pipeline-trigger |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 84, in compose_node
kernelci-pipeline-trigger |     node = self.compose_mapping_node(anchor)
kernelci-pipeline-trigger |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 133, in compose_mapping_node
kernelci-pipeline-trigger |     item_value = self.compose_node(node, item_key)
kernelci-pipeline-trigger |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/yaml/composer.py", line 68, in compose_node
kernelci-pipeline-trigger |     raise ComposerError(None, None, "found undefined alias %r"
kernelci-pipeline-trigger | yaml.composer.ComposerError: found undefined alias 'tast-decoder-v4l2-sl-av1-job'
kernelci-pipeline-trigger |   in "config/jobs-chromeos.yaml", line 417, column 44

@JenySadadia JenySadadia added the staging-skip Don't test automatically on staging.kernelci.org label Mar 4, 2024
@a-wai a-wai force-pushed the add-tast-codec-tests branch from d4e1db0 to 8cfea2a Compare March 4, 2024 09:59
@a-wai
Copy link
Contributor Author

a-wai commented Mar 4, 2024

Adding staging-skip due to below errors on staging:

Fixed, sorry about that!

@a-wai a-wai removed the staging-skip Don't test automatically on staging.kernelci.org label Mar 4, 2024
@a-wai
Copy link
Contributor Author

a-wai commented Mar 4, 2024

@laura-nao Thanks for the review! One thing I was wondering: could we make vp9-group{1,2,3,4} a single job? It seems those should always run on the same platforms, unless you anticipate changes to happen there?

We might also group vp9-level5 and vp9-svc a single job named vp9-extra for instance, although I don't know if this would really make sense.

@a-wai a-wai force-pushed the add-tast-codec-tests branch 2 times, most recently from 695271d to c304dd4 Compare March 4, 2024 14:37
@laura-nao
Copy link
Contributor

@laura-nao Thanks for the review! One thing I was wondering: could we make vp9-group{1,2,3,4} a single job? It seems those should always run on the same platforms, unless you anticipate changes to happen there?

We might also group vp9-level5 and vp9-svc a single job named vp9-extra for instance, although I don't know if this would really make sense.

@a-wai when I first added these tests in the legacy system, I noticed that a job running all vp9 tests would exceed 10 minutes so I opted for splitting them into groups. I'm not against combining them into a single suite (especially if it makes more sense from a resource usage pov), it will just take more time to execute and I'm not sure if the best practice of avoiding jobs >10min still stands for the new system or not.

@a-wai
Copy link
Contributor Author

a-wai commented Mar 5, 2024

@laura-nao well we already have multiple Tast jobs >10mins, so I'd say this "rule" at least has a few exceptions, Tast tests being one of them. I'll proceed with grouping tests as I suggested then, if it doesn't work we can always revert that later.

Those were left aside for the initial implementation, we can bring them
back now we're confident Tast tests generally run as expected on the new
system.

Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
@a-wai a-wai force-pushed the add-tast-codec-tests branch from c304dd4 to f9771d1 Compare March 5, 2024 09:42
Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests being run, might be failing now, but this might be next step fixing minor details
https://staging.kernelci.org:9000/viewer?search=parent%3D65eac74577d9d88b36edbb6b

@nuclearcat nuclearcat added this pull request to the merge queue Mar 8, 2024
Merged via the queue into kernelci:main with commit e7b9e1e Mar 8, 2024
3 checks passed
@a-wai a-wai deleted the add-tast-codec-tests branch March 8, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants