Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capabilities_negotiation structures #945

Conversation

sarroutbi
Copy link
Contributor

@sarroutbi sarroutbi commented Feb 24, 2025

This change aims to include those structures
that will be required to communicate
capabilities negotiation information for
Keylime Push model

Resolves: #933
Signed-off-by: Sergio Arroutbi sarroutb@redhat.com

@sarroutbi sarroutbi force-pushed the 202502241231-add-capabilities-negotiation-structure branch 4 times, most recently from 105cfde to f4029ca Compare February 24, 2025 12:07
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.26%. Comparing base (3b6c0ff) to head (ad48d7c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
keylime/src/structures/capabilities_negotiation.rs 69.56% 7 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 62.26% <69.56%> (+0.02%) ⬆️
upstream-unit-tests 62.26% <69.56%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime/src/structures/capabilities_negotiation.rs 69.56% <69.56%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@ansasaki ansasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going to the right direction, it just need some adjustments.

I'll try to create the draft for my proposal of JSON schemas ASAP

@sarroutbi sarroutbi force-pushed the 202502241231-add-capabilities-negotiation-structure branch 8 times, most recently from d1d0676 to 427c8f1 Compare February 25, 2025 16:49
@sarroutbi sarroutbi requested a review from ansasaki February 25, 2025 16:57
@sarroutbi sarroutbi force-pushed the 202502241231-add-capabilities-negotiation-structure branch 12 times, most recently from 9dd7856 to 1d2c140 Compare February 26, 2025 12:12
This change aims to include those structures
that will be required to communicate
capabilities negotiation information for
Keylime Push model

Resolves: keylime#933
Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
@sarroutbi sarroutbi force-pushed the 202502241231-add-capabilities-negotiation-structure branch from 1d2c140 to ad48d7c Compare February 26, 2025 12:57
@ansasaki
Copy link
Contributor

I created JSON schemas that I believe (sorry, I didn't test) can validate the data format as it is in this PR:
https://gist.github.com/ansasaki/4c4b0159cfc4f8b85900cb86ff333ed9

Copy link
Contributor

@ansasaki ansasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this is a good initial set of structs for the attestation parameters negotiation.

@ansasaki ansasaki merged commit 329329d into keylime:master Feb 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[agent] Define schemas for capabilities negotiation during PoP authentication
2 participants