-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capabilities_negotiation structures #945
Add capabilities_negotiation structures #945
Conversation
105cfde
to
f4029ca
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is going to the right direction, it just need some adjustments.
I'll try to create the draft for my proposal of JSON schemas ASAP
d1d0676
to
427c8f1
Compare
9dd7856
to
1d2c140
Compare
This change aims to include those structures that will be required to communicate capabilities negotiation information for Keylime Push model Resolves: keylime#933 Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
1d2c140
to
ad48d7c
Compare
I created JSON schemas that I believe (sorry, I didn't test) can validate the data format as it is in this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think this is a good initial set of structs for the attestation parameters negotiation.
This change aims to include those structures
that will be required to communicate
capabilities negotiation information for
Keylime Push model
Resolves: #933
Signed-off-by: Sergio Arroutbi sarroutb@redhat.com