Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSW broken with npm build build:msw #43

Closed
praseodym opened this issue May 17, 2024 · 3 comments · Fixed by #46
Closed

MSW broken with npm build build:msw #43

praseodym opened this issue May 17, 2024 · 3 comments · Fixed by #46
Labels
bug Something isn't working frontend Issues or pull requests that relate to the frontend

Comments

@praseodym
Copy link
Contributor

When building using npm build build:msw, the Mock Service Worker (MSW) is broken and API calls get routed directly to the server. This needs to be fixed for us to be able to host an online test version.
@praseodym praseodym added bug Something isn't working frontend Issues or pull requests that relate to the frontend labels May 17, 2024
@praseodym praseodym moved this from Options to Current in Abacus Development May 17, 2024
@lkleuver
Copy link
Contributor

this is with the data entry branch?

@praseodym
Copy link
Contributor Author

praseodym commented May 17, 2024 •
edited
Loading

this is with the data entry branch?

Yes it is! Apparently I didn't test on main, because there it does work. On the data-entry-api-frontend branch (#31), building using npm run build:msw also shows "Server Live" (instead of "Server Mocked") in the footer.

@praseodym
Copy link
Contributor Author

Fixed by #46

@github-project-automation github-project-automation bot moved this from Current to Done in Abacus Development May 17, 2024
@praseodym praseodym linked a pull request May 17, 2024 that will close this issue
Fix MSW build #46
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend Issues or pull requests that relate to the frontend
Projects
Abacus Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix MSW build kiesraad/abacus
2 participants
@praseodym @lkleuver