Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSW build #46

Merged
merged 2 commits into from
May 17, 2024
Merged

Fix MSW build #46

merged 2 commits into from
May 17, 2024

Conversation

lkleuver
Copy link
Contributor

Fix the build:msw option for static hosting

@lkleuver lkleuver marked this pull request as ready for review May 17, 2024 11:43
@lkleuver lkleuver requested review from praseodym and Lionqueen94 May 17, 2024 11:43
@praseodym praseodym changed the title Mock api static build fix Fix MSW build May 17, 2024
@praseodym
Copy link
Contributor

I rebased this on top of main.

praseodym
praseodym approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@praseodym praseodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, works again!

@praseodym praseodym merged commit 25e6ce6 into main May 17, 2024
2 checks passed
@praseodym praseodym deleted the 43-build-msw-fix branch May 17, 2024 11:57
@praseodym praseodym mentioned this pull request May 17, 2024
Closed
@praseodym praseodym linked an issue May 17, 2024 that may be closed by this pull request
MSW broken with npm build build:msw #43
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praseodym praseodym praseodym approved these changes

@Lionqueen94 Lionqueen94 Lionqueen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSW broken with npm build build:msw
3 participants
@lkleuver @praseodym @Lionqueen94