Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend initial commit #1

Merged
merged 11 commits into from
Mar 19, 2024
Merged

Frontend initial commit #1

merged 11 commits into from
Mar 19, 2024

Conversation

lkleuver
Copy link
Contributor

@lkleuver lkleuver commented Mar 8, 2024 •
edited by praseodym
Loading

First setup of the frontend codebase, based off POC
build, dev, test and lint.

Closes #4

@lkleuver
Frontend initial commit
c1b1cb1 
Add boilerplate frontend code
Add unit test setup
Add e2e test setup
Add github frontend test workflow
@lkleuver lkleuver closed this Mar 8, 2024
@lkleuver lkleuver reopened this Mar 8, 2024
@jschuurk-kr
Copy link
Contributor

Is het handig om een .nvmrc toe te voegen? Of op een andere manier vast te leggen welke versie van Node we gebruiken?

@praseodym praseodym changed the title initial commit Frontend initial commit Mar 8, 2024
@lkleuver
Copy link
Contributor Author

lkleuver commented Mar 8, 2024

Is het handig om een .nvmrc toe te voegen? Of op een andere manier vast te leggen welke versie van Node we gebruiken?

Ja, zeker. alleen ben ik er niet over uit welke versie.
in ieder geval 16+

vooral SSL dingen hebben hier volgens mij invloed op.

@praseodym
Copy link
Contributor

Node.js 20 is nu de huidige LTS ("Recommended For Most Users"), dus ik stel voor dat we die gebruiken.

@lkleuver
Add lint rules
f15ed91 
Fix lint warnings
praseodym
praseodym requested changes Mar 8, 2024
View reviewed changes
jschuurk-kr
jschuurk-kr reviewed Mar 8, 2024
View reviewed changes
lkleuver added 6 commits March 11, 2024 09:49
@lkleuver
Moved .nvmrc to frontend
cff1a66 
Added build:msw for mocked static site
Tested npm run preview (after build:msw)
@lkleuver
Moved .nvmrc to frontend
e022c8e 
Added build:msw for preview of static site
@lkleuver
Add stricter typescript rules
8577f32
@lkleuver
removed empty string
ae363b0
@lkleuver
Fixed linting
40e0028
@lkleuver
Merge branch 'main' into frontend.initial
b91e82b
@praseodym
Copy link
Contributor

npm run build gives an error for me:

> urn-uitslag@0.0.1 build
> tsc && vite build

vite.config.ts:24:42 - error TS2532: Object is possibly 'undefined'.

24       (paths) => path.resolve(__dirname, paths[0].replace("/*", ""))
                                            ~~~~~~~~


Found 1 error in vite.config.ts:24

praseodym
praseodym previously approved these changes Mar 15, 2024
View reviewed changes
@lkleuver lkleuver merged commit 8b1e823 into main Mar 19, 2024
1 check passed
@lkleuver lkleuver deleted the frontend.initial branch March 19, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praseodym praseodym praseodym approved these changes

@jschuurk-kr jschuurk-kr jschuurk-kr approved these changes

Assignees

@praseodym praseodym

@jschuurk-kr jschuurk-kr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geraamte frontend opzetten
3 participants
@lkleuver @jschuurk-kr @praseodym