-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data entry for polling station results #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump version numbers and remove unnecessary default features for sqlx.
Initial version with only voter and votes counts.
61c8db9
to
530bf1d
Compare
530bf1d
to
916a7a2
Compare
praseodym
commented
Mar 29, 2024
jschuurk-kr
reviewed
Apr 2, 2024
jschuurk-kr
reviewed
Apr 2, 2024
- Change table primary key to `(polling_station_id, entry_number)` - Add `entry_number` to path instead of request body - Add 422 Unprocessable Content to OpenAPI spec, used for JSON decode errors. Also add a test for this.
lkleuver
previously approved these changes
Apr 3, 2024
jschuurk-kr
reviewed
Apr 3, 2024
Co-authored-by: Joep Schuurkes <145749778+jschuurk-kr@users.noreply.github.com>
jschuurk-kr
previously approved these changes
Apr 3, 2024
lkleuver
previously approved these changes
Apr 8, 2024
lkleuver
approved these changes
Apr 8, 2024
jschuurk-kr
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version with only voter and votes counts.
Closes #6