-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend: use API to show list of polling stations on polling station select page #146
Frontend: use API to show list of polling stations on polling station select page #146
Conversation
f998f54
to
e44a7cb
Compare
e44a7cb
to
6eace63
Compare
6eace63
to
ccaf062
Compare
ccaf062
to
ff4eead
Compare
That's weird, that was fixed here: #143. I'll rebase main |
ff4eead
to
3f849e0
Compare
3f849e0
to
38f93ef
Compare
Two things I noticed in my brief look at the preview environment:
|
frontend/app/component/form/polling_station_choice/PollingStationSelector.tsx
Outdated
Show resolved
Hide resolved
Added the styling
This will be fixed in #108 |
@jorisleker I've fixed the design issues and added a debounce on the user input. I purposely left the badge out, as @jschuurk-kr mentioned earlier in a review that we should leave out design placeholders, and the badge logic is not implemented yet. |
My reasoning about the placeholders: I was starting to find it hard to look at the page, check what's in scope of the PR, identify which parts of the page had been implemented and which parts are placeholders, and then decide what to review/test for the PR. That left me with less mental bandwidth for testing/reviewing than I liked. So for pages we're actively working on, I'm in favor of either removing placeholders or having placeholders that are clearly placeholders. In this case that could be the badge saying "invoerstatus" instead of "1ste invoer". |
The PR description still says:
I think that's outdated and can be removed? |
In this case the Badge is typed in an object, so I'd have to add a placeholder field, or create a seperate placeholder badge, so I'll just leave it out for now. The Badges are still present in the code as commented TODO's, so they'll be trivial to find and implement, once we get to that. |
f9ece10
to
027abf6
Compare
027abf6
to
93c5df9
Compare
I think all feedback is either implemented or delegated to other issues |
This PR replaces hard coded polling stations with polling stations provided by the backend. It also adds a lookup when the user enters a polling station number.