Update Frontend Preview workflow #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only deploy to the preview environment for pull requests and pushes to the `main` branch. This avoids deploys for temporary merge queue branches and other branches where we don't need previews.
Lionqueen94
previously approved these changes
Jul 19, 2024
|
Looks like the Cloudflare Wrangler action doesn't detect the branch name from the |
The Cloudflare Wrangler action doesn't detect the branch name for `pull_request` triggers, so we have to specify it explicitly.
Fixed with the latest commit. https://update-frontend-preview-work.kiesraad-abacus.pages.dev/ was deployed successfully 😄 |
Lionqueen94
approved these changes
Jul 19, 2024
cikzh
reviewed
Jul 22, 2024
They'll be built for pull requests, won't that be sufficient? |
I misread, this is perfect 👍 |
cikzh
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only deploy to the preview environment for pull requests and pushes to the
mainbranch. This avoids deploys for temporary merge queue branches and other branches where we don't need previews.