Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recounted, voters_recounts and differences fields to api including validation and voters_recounts to frontend #166

Merged
merged 53 commits into from
Aug 9, 2024
Merged

Add recounted, voters_recounts and differences fields to api including validation and voters_recounts to frontend #166

merged 53 commits into from
Aug 9, 2024

Conversation

Lionqueen94
Copy link
Contributor

@Lionqueen94 Lionqueen94 commented Jul 19, 2024 •
edited
Loading

Closes #110
Closes #113

TODO:

  • Add rule W.306 to backend and mock and add test

@Lionqueen94 Lionqueen94 requested a review from praseodym July 19, 2024 12:40
@Lionqueen94 Lionqueen94 self-assigned this Jul 19, 2024
@Lionqueen94 Lionqueen94 linked an issue Jul 19, 2024 that may be closed by this pull request
Backend: add 'recounted', 'differences' fields to API, including validation #110
Closed
3 tasks
jschuurk-kr
jschuurk-kr reviewed Jul 23, 2024
View reviewed changes
@Lionqueen94 Lionqueen94 requested a review from cikzh August 2, 2024 14:34
@praseodym praseodym added backend Issues or pull requests that relate to the backend frontend Issues or pull requests that relate to the frontend labels Aug 7, 2024
@Lionqueen94 Lionqueen94 requested a review from jschuurk-kr August 8, 2024 10:16
@praseodym praseodym requested a review from chrismostert August 9, 2024 07:54
@Lionqueen94 Lionqueen94 enabled auto-merge August 9, 2024 10:18
@Lionqueen94 Lionqueen94 added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit 688775d Aug 9, 2024
7 checks passed
@Lionqueen94 Lionqueen94 deleted the 110-backend-add-recounted-differences-fields-to-api-including-validation branch August 9, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praseodym praseodym praseodym approved these changes

@jschuurk-kr jschuurk-kr jschuurk-kr approved these changes

@lkleuver lkleuver Awaiting requested review from lkleuver

@jorisleker jorisleker Awaiting requested review from jorisleker

@cikzh cikzh Awaiting requested review from cikzh

@chrismostert chrismostert Awaiting requested review from chrismostert

Assignees

@praseodym praseodym

@Lionqueen94 Lionqueen94

Labels
backend Issues or pull requests that relate to the backend frontend Issues or pull requests that relate to the frontend
Projects
None yet
Milestone
No milestone
5 participants
@Lionqueen94 @jschuurk-kr @praseodym @jorisleker @chrismostert