Improve polling station form tests #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praseodym
changed the title
praseodym
previously approved these changes
Jul 25, 2024
jschuurk-kr
requested changes
Jul 25, 2024
There was a problem hiding this comment.
This PR leaves out the 404 test as discussed in the issue, as it is dependent on the decision made in #179
We can cover the current behavior with a test. To me, that too, is part of the zero bug policy.
Lionqueen94
requested changes
Jul 26, 2024
frontend/app/component/form/polling_station_choice/PollingStationChoiceForm.test.tsx
Outdated
Show resolved
Hide resolved
cikzh
force-pushed
the
163-improve-polling-station-form-tests
branch
from
4c0aded to
0b27d70
Compare
Lionqueen94
reviewed
Jul 26, 2024
frontend/app/component/form/polling_station_choice/PollingStationChoiceForm.test.tsx
Outdated
Show resolved
Hide resolved
Lionqueen94
previously approved these changes
Jul 29, 2024
praseodym
previously approved these changes
Jul 29, 2024
jschuurk-kr
approved these changes
Jul 29, 2024
Lionqueen94
approved these changes
Jul 29, 2024
praseodym
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163
Using
overrideOnceat the start of every test to make clear what data is used for the test. Also making it more explicit when testing edge cases.This PR leaves out the 404 test as discussed in the issue, as it is dependent on the decision made in #179