Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives in tests #199

Conversation

cikzh
Copy link
Contributor

@cikzh cikzh commented Jul 29, 2024

Closes #108

Since most of issue #108 will be fixed in #197 and #193, this PR now only addresses the tests

  • Adds an API endpoint to fetch a single Polling Station implemented in Fix showing of polling station number on input pages #197
  • Updated tests so that the 'fetch spies' are ran after rendering, this prevents unintentionally triggering on API calls in providers.
  • Updated tests so that the test waits (findBy* calls) for the expected components to appear, since we now show a spinner while loading data from the backend.

@cikzh cikzh linked an issue Jul 29, 2024 that may be closed by this pull request
@cikzh cikzh force-pushed the 108-frontend-submit-data-entry-using-correct-polling-station-information branch from 6d78e5e to 8888435 Compare July 31, 2024 13:02
@cikzh cikzh force-pushed the 108-frontend-submit-data-entry-using-correct-polling-station-information branch from 8888435 to 34eab70 Compare August 1, 2024 09:37
@cikzh cikzh changed the title Submit data entry using correct polling station information Fix false positives in tests Aug 1, 2024
@cikzh cikzh marked this pull request as ready for review August 1, 2024 13:34
@cikzh cikzh added the tests Issues or pull requests that relate to tests label Aug 2, 2024
@cikzh cikzh added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit eb401fc Aug 5, 2024
5 checks passed
@cikzh cikzh deleted the 108-frontend-submit-data-entry-using-correct-polling-station-information branch August 5, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues or pull requests that relate to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend: submit data entry using correct polling station information
3 participants